How severe does this issue affect your experience of using Ray?
- None: Just asking a question out of curiosity
Hi, I’ve implemented an easy action masking method in
compute_q_values for DQN (including dueling and distributional). I made a fork with my commited changes, but I don’t want to have anti-patterns so I’m looking for feedback here. (Am I even in the right place?)
For now I have only implemented the changes in torch and it requires having an additional attribute in the DQN model (optional attribute which shouldn’t affect older code nor people who don’t want to use the feature). The workflow from older versions of ray (i.e. redefining a custom model) is not changed.