# How to contribute a proposal for an adapted advantage computation to RLlib

**URL:** <https://discuss.ray.io/t/how-to-contribute-a-proposal-for-an-adapted-advantage-computation-to-rllib/4314>\
**Category:** RLlib\
**Created:** [December 1, 2021, 12:43pm UTC](https://discuss.ray.io/t/how-to-contribute-a-proposal-for-an-adapted-advantage-computation-to-rllib/4314 "2021-12-01T12:43:14Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![klausk55](https://avatars.discourse-cdn.com/v4/letter/k/f17d59/32.png) [@klausk55](https://discuss.ray.io/u/klausk55)\
**Post date:** [December 1, 2021, 12:43pm UTC](https://discuss.ray.io/t/how-to-contribute-a-proposal-for-an-adapted-advantage-computation-to-rllib/4314/1 "2021-12-01T12:43:14Z")

</div>

Hey guys,

I implemented a proposal for an adapted advantage compution (which could be used by PPO). My implemented example shows how this adapted advantage compution can be done via the custom callback function `on_postprocess_trajectory`. Maybe it is also helpful and interesting for other people, therefore how can I contribute my proposal to RLlib? Open an issue on Github?

---

<div class="post-metadata">

**Author:** ![Lars\_Simon\_Zehnder](https://sea2.discourse-cdn.com/flex020/user_avatar/discuss.ray.io/lars_simon_zehnder/32/1185_2.png) [@Lars\_Simon\_Zehnder](https://discuss.ray.io/u/Lars_Simon_Zehnder)\
**Post date:** [December 1, 2021, 8:33pm UTC](https://discuss.ray.io/t/how-to-contribute-a-proposal-for-an-adapted-advantage-computation-to-rllib/4314/2 "2021-12-01T20:33:56Z")

</div>

Ho @klausk55 ,

great initiative! If you want to contribute to rllib read first the notes on [Getting Involved](https://docs.ray.io/en/latest/getting-involved.html).

In your case I suppose the right place for your proposal would be in [rllib/examples](https://github.com/ray-project/ray/tree/master/rllib/examples).

Hope this helps to get it on

---

<div class="post-metadata">

**Author:** ![klausk55](https://avatars.discourse-cdn.com/v4/letter/k/f17d59/32.png) [@klausk55](https://discuss.ray.io/u/klausk55)\
**Post date:** [December 2, 2021, 5:03pm UTC](https://discuss.ray.io/t/how-to-contribute-a-proposal-for-an-adapted-advantage-computation-to-rllib/4314/3 "2021-12-02T17:03:28Z")

</div>

See [PR](https://github.com/ray-project/ray/pull/20850)

---

<div class="post-metadata">

**Author:** ![Lars\_Simon\_Zehnder](https://sea2.discourse-cdn.com/flex020/user_avatar/discuss.ray.io/lars_simon_zehnder/32/1185_2.png) [@Lars\_Simon\_Zehnder](https://discuss.ray.io/u/Lars_Simon_Zehnder)\
**Post date:** [December 3, 2021, 3:52pm UTC](https://discuss.ray.io/t/how-to-contribute-a-proposal-for-an-adapted-advantage-computation-to-rllib/4314/4 "2021-12-03T15:52:28Z")

</div>

@klausk55 Nice work! I wrote a comment in the PR regarding the CI tests that did not pass.